dajac commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1938170491
> @dajac Maybe I misunderstand, but I don't see how the change you linked is relevant. If you run the tests once (as in locally running `./gradlew unitTest`) then the retries and merging of flaky tests in XML doesn't have an effect. And if you're using retries and merging the XML (as in Jenkins), you aren't using the unitTest target. @gharris1727 Yeah, that's right. I was thinking about it from a CI point of view. > A flaky test cannot be a unit test in my opinion. Unit tests are meant to be deterministic and fast. Anything that doesn't fit that definition should be tagged as integration test. @ijuma I don't disagree. However, I think that they are tests that we should rather fix vs classifying them as integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
