OmniaGM commented on code in PR #15341:
URL: https://github.com/apache/kafka/pull/15341#discussion_r1486534681
##########
streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java:
##########
@@ -102,13 +101,14 @@ public EmbeddedKafkaCluster(final int numBrokers,
/**
* Creates and starts a Kafka cluster.
*/
- public void start() throws IOException {
+ public void start() throws Exception {
log.debug("Initiating embedded Kafka cluster startup");
- log.debug("Starting a ZooKeeper instance");
- zookeeper = new EmbeddedZookeeper();
- log.debug("ZooKeeper instance is running at {}", zKConnectString());
+ final KafkaClusterTestKit.Builder clusterBuilder = new
KafkaClusterTestKit.Builder(
+ new TestKitNodes.Builder()
+ .setNumControllerNodes(1)
Review Comment:
Any reason why we don't setup the cluster with combined nodes and number of
controllers == number of brokers instead of one controller and one broker?
Specially that as far as I can see all the test set number of brokers to 1
anyway. This also can get us to remove `KafkaEmbedded` which might simplify the
setup! WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
