OmniaGM commented on PR #15341: URL: https://github.com/apache/kafka/pull/15341#issuecomment-1943628282
> Thanks for the comments! I just realized that the PR can use additional improvements, i.e. I can get rid of `KafkaEmbedded` since with KRaft you can set up the entire Kafka cluster (i.e. brokers + controllers) using the `KafkaClusterTestKit.Builder`. Thanks for taking the comments into consideration. One other suggestion is that we can have a look into #13375 to see what is the common between both `EmbeddedKafkaCluster` in stream and connect and see if we can have one common `EmbeddedKafkaCluster` between both of them. And later move connect to use it. Which also can be follow up JIRA if we want to keep this one simple. Either way I'm happy to lend a hand in the connect part if needed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org