jlprat commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1487661551
##########
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##########
@@ -238,7 +237,8 @@ private Set<String> checkConsumerGroup(Properties
consumerPropsFromFile, Propert
}
private Properties buildConsumerProps(Properties consumerPropsFromFile,
Properties extraConsumerProps, Set<String> groupIdsProvided) {
- Properties consumerProps = new Properties(consumerPropsFromFile);
+ Properties consumerProps = new Properties();
+ consumerProps.putAll(consumerPropsFromFile);
Review Comment:
Strange that this change is not doing the exact same thing. But reading the
API, constructor with `Property` says that it creates an empty list with the
passed properties as defaults. Tricky API design from Java's part...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
