mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1487675184
##########
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##########
@@ -238,7 +237,8 @@ private Set<String> checkConsumerGroup(Properties
consumerPropsFromFile, Propert
}
private Properties buildConsumerProps(Properties consumerPropsFromFile,
Properties extraConsumerProps, Set<String> groupIdsProvided) {
- Properties consumerProps = new Properties(consumerPropsFromFile);
+ Properties consumerProps = new Properties();
+ consumerProps.putAll(consumerPropsFromFile);
Review Comment:
Yep! Default values are only retrieved when using `getProperty()` and not
when using `get()`. This is why the unit test was passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
