lianetm commented on code in PR #15375:
URL: https://github.com/apache/kafka/pull/15375#discussion_r1491204862
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -335,8 +335,13 @@ public int memberEpoch() {
return memberEpoch;
}
+ /**
+ * @return True if there hasn't been a call to consumer.poll() withing the
max.poll.interval.
+ * In that case, it is expected that the member will leave the group and
rejoin on the next
+ * call to consumer.poll().
+ */
@Override
- public boolean isStaled() {
+ public boolean isStale() {
Review Comment:
I would guess that @philipnee preferred the convenience method when he added
it, to use it from the HBManager. That being said, your comment made me notice
that the isStale is not used anymore there, so removing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
