jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492849366
########## tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java: ########## @@ -436,16 +436,25 @@ public String name() { @Override public void addSubparser(Subparsers subparsers) { - subparsers.addParser(name()) + Subparser subparser = subparsers.addParser(name()) .help("list transactions"); + + subparser.addArgument("--duration-filter") + .help("filter duration of transaction in ms, only transactions running longer than this duration will be returned") Review Comment: we should mention the default/value that gives all running transactions. Providing 0 and getting a ton of transactions might be confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org