jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1493039266
########## clients/src/main/resources/common/message/ListTransactionsRequest.json: ########## @@ -18,14 +18,18 @@ "type": "request", "listeners": ["zkBroker", "broker"], "name": "ListTransactionsRequest", - "validVersions": "0", + // version 1: adds DurationFilter to list transactions older than specified duration Review Comment: nit: most specs capitalize V here. ########## clients/src/main/resources/common/message/ListTransactionsResponse.json: ########## @@ -17,7 +17,8 @@ "apiKey": 66, "type": "response", "name": "ListTransactionsResponse", - "validVersions": "0", + // Version 1 is the same as vesion 0 (KIP-994). Review Comment: nit: version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org