cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1953872828
> I was wondering whether we should introduce a new error code to signal to
the user that the regular expression is invalid. Otherwise, we would have to
use the invalid request exception and it does not seem user friendly. @cadonna
@lianetm What do you think about this?
@dajac Is it also possible to verify the validity of the regular expression
client-side?
If we assume that the clients send valid regular expressions to the brokers,
I think it would be OK to return an invalid request exception and log the error
broker-side. Sending invalid regular expressions should than just be a mistake
that happens during development of the clients and not something that happens
during usage of the clients.
The benefit would be to find the mistakes in regular expressions without a
request to the brokers.
The downside of it is that we need some way to validate the regular
expressions client-side like the corresponding Google library in Java and I do
not know what dependency are needed for clients in other languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
