lianetm commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-1961610927
Regarding the validation of the regex, I lean towards having a new error, like @dajac suggested. Just to clearly tell the user that it is using an invalid regex, without overcomplicating the experience with an InvalidRequest that would have the user wondering what exactly went wrong, probably hinting a a much larger surface area, since it indicates that something wen't wrong in the client/server interaction. This means I think it's better to validate it on the client side too. I could be missing something, but to my understanding, the point of avoiding the new regex engine on the client was not to avoid the dependency itself, it was more a position we still keep, that the broker is the sole responsible for resolving the topics to include in a subscription when a regex is used. We would still keep that principle if we introduce the dependency on the client just to validate the regex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
