jolshan commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500128231
########## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ########## @@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig { + "Enabling idempotence requires this config value to be greater than 0." + " If conflicting configurations are set and idempotence is not explicitly enabled, idempotence is disabled." + "<p>" - + "Allowing retries while setting <code>enable.idempotence</code> to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code> to 1 will potentially change the" + + "Allowing retries while setting <code>enable.idempotence</code> to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code> to greater than 1 will potentially change the" Review Comment: Not sure if we wanted to include a note about this or not. Just something like noting that inflight requests = 1 does not guarantee idempotency due to how TCP connections work with Kafka. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org