federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500197041
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
+ "Enabling idempotence requires this config value to be greater
than 0."
+ " If conflicting configurations are set and idempotence is not
explicitly enabled, idempotence is disabled."
+ "<p>"
- + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to 1 will potentially change the"
+ + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to greater than 1 will potentially change the"
Review Comment:
Yes, I guess that if that is the case the whole comment is a little
outdated, since no matter inflight requests value but just idempotency to
guarantee partition ordering, not for me to decide about this, but I think that
this point should be clear as ordering is an important feature of kafka
partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
