dajac commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1509278562
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData()
{
data.setMemberEpoch(membershipManager.memberEpoch());
// InstanceId - only sent if has changed since the last heartbeat
Review Comment:
The current implementation actually requires the static member id to be set
all the time if the consumer uses the static membership. So the comment in the
schema was wrong. I need to go back to the implementation to see whether we
could relax it and only require it in the first request, when joining. I will
check and let you guys know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
