mjsax commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1509341591
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData()
{
data.setMemberEpoch(membershipManager.memberEpoch());
// InstanceId - only sent if has changed since the last heartbeat
Review Comment:
I think "setting the id all the time" vs "omitting it" is an important but
orthogonal question. -- The comment say that it must be set "if has changed",
but it should never change, right?
> So the comment in the schema was wrong
Is this about setting the id vs not setting it, or about the original
question if it could change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
