dajac commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1514092183
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -2276,6 +2399,11 @@ private Node leader(PartitionInfo partitionInfo) {
return partitionInfo.leader();
}
+ // This is used in the describe topics path if using
DescribeTopicPartitions API.
+ private Node replicaToFakeNode(int id) {
+ return new Node(id, "Dummy", 0);
Review Comment:
Don't we break the contract of the admin api if we do this? The expectation
is that the real nodes are returned. We could perhaps get them from the
metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
