CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1515057124
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {
return partitionInfo.leader();
}
+ // This is used in the describe topics path if using DescribeTopics API.
+ private Node replicaToFakeNode(int id) {
+ return new Node(id, "Dummy", 0);
+ }
Review Comment:
Now it will query the cluster info for the nodes.
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -2276,6 +2399,11 @@ private Node leader(PartitionInfo partitionInfo) {
return partitionInfo.leader();
}
+ // This is used in the describe topics path if using
DescribeTopicPartitions API.
+ private Node replicaToFakeNode(int id) {
+ return new Node(id, "Dummy", 0);
Review Comment:
Good point. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
