hni61223 commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1514278368
##########
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##########
@@ -677,4 +675,38 @@ object KafkaMetadataLog extends Logging {
Snapshots.deleteIfExists(logDir, snapshotId)
}
}
+
+ private sealed trait SnapshotDeletionReason {
+ def reason(snapshotId: OffsetAndEpoch): String
+ }
+
+ private final case class RetentionMsBreach(now: Long, timestamp: Long,
retentionMillis: Long) extends SnapshotDeletionReason {
+ override def reason(snapshotId: OffsetAndEpoch): String = {
+ s"""Marking snapshot $snapshotId for deletion because it timestamp
($timestamp) is now ($now) older than the
Review Comment:
nit: its timestamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
