mimaison commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1539776305
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -58,6 +61,8 @@ public class AbstractConfig {
private final ConfigDef definition;
+ public static final String AUTOMATIC_CONFIG_PROVIDERS_PROPERTY =
"org.apache.kafka.automatic.config.providers";
Review Comment:
I'm not sure on the naming. What about
`org.apache.kafka.allowed.config.providers`?
##########
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##########
@@ -461,6 +497,25 @@ public void
testAutoConfigResolutionWithInvalidConfigProviderClass() {
}
}
+ @Test
+ public void
testAutoConfigResolutionWithInvalidConfigProviderClassExcluded() {
+ System.setProperty(AbstractConfig.AUTOMATIC_CONFIG_PROVIDERS_PROPERTY,
"");
Review Comment:
Should we also have a test with the property containing a list of providers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
