dongnuo123 commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1555021412
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##########
@@ -1244,6 +1267,24 @@ public boolean completeSyncFuture(
return false;
}
+ /**
+ * Complete all the awaiting sync future with the give error.
+ *
+ * @param error the error to complete the future with.
+ */
+ public void completeAllSyncFutures(
+ Errors error
+ ) {
+ members.forEach((__, member) -> completeSyncFuture(
+ member,
+ new SyncGroupResponseData()
+ .setProtocolName(protocolName.orElse(null))
+ .setProtocolType(protocolType.orElse(null))
+ .setAssignment(member.assignment())
Review Comment:
We did set them in `resetAndPropagateAssignmentWithError(group,
Errors.REBALANCE_IN_PROGRESS);` but I don't think they are necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
