dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1566001316
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -1046,4 +1051,101 @@ public void testIsInStatesCaseInsensitive() {
assertTrue(group.isInStates(Collections.singleton("stable"), 1));
assertFalse(group.isInStates(Collections.singleton("empty"), 1));
}
+
+ @Test
+ public void testClassicMembersSupportedProtocols() {
+ ConsumerGroup consumerGroup = createConsumerGroup("foo");
+ List<ConsumerGroupMemberMetadataValue.ClassicProtocol> rangeProtocol =
new ArrayList<>();
+ rangeProtocol.add(new
ConsumerGroupMemberMetadataValue.ClassicProtocol()
+ .setName("range")
+ .setMetadata(new byte[0]));
+
+ List<ConsumerGroupMemberMetadataValue.ClassicProtocol>
roundRobinAndRangeProtocols = new ArrayList<>();
+ roundRobinAndRangeProtocols.add(new
ConsumerGroupMemberMetadataValue.ClassicProtocol()
+ .setName("roundrobin")
+ .setMetadata(new byte[0]));
+ roundRobinAndRangeProtocols.add(new
ConsumerGroupMemberMetadataValue.ClassicProtocol()
+ .setName("range")
+ .setMetadata(new byte[0]));
+
+ ConsumerGroupMember member1 = new
ConsumerGroupMember.Builder("member-1")
+ .setClassicMemberMetadata(new
ConsumerGroupMemberMetadataValue.ClassicMemberMetadata()
+ .setSupportedProtocols(rangeProtocol))
+ .build();
+ consumerGroup.updateMember(member1);
+
+ ConsumerGroupMember member2 = new
ConsumerGroupMember.Builder("member-2")
+ .setClassicMemberMetadata(new
ConsumerGroupMemberMetadataValue.ClassicMemberMetadata()
+ .setSupportedProtocols(roundRobinAndRangeProtocols))
+ .build();
+ consumerGroup.updateMember(member2);
+
+ assertEquals(2,
consumerGroup.classicMembersSupportedProtocols().get("range"));
+ assertEquals(1,
consumerGroup.classicMembersSupportedProtocols().get("roundrobin"));
+
assertTrue(consumerGroup.supportsClassicProtocols(ConsumerProtocol.PROTOCOL_TYPE,
new HashSet<>(Arrays.asList("range", "sticky"))));
+
assertFalse(consumerGroup.supportsClassicProtocols(ConsumerProtocol.PROTOCOL_TYPE,
new HashSet<>(Arrays.asList("sticky", "roundrobin"))));
+
+ member2 = new ConsumerGroupMember.Builder(member2)
+ .setClassicMemberMetadata(new
ConsumerGroupMemberMetadataValue.ClassicMemberMetadata()
+ .setSupportedProtocols(rangeProtocol))
+ .build();
+ consumerGroup.updateMember(member2);
+
+ assertEquals(2,
consumerGroup.classicMembersSupportedProtocols().get("range"));
+
assertFalse(consumerGroup.classicMembersSupportedProtocols().containsKey("roundrobin"));
+
+ member1 = new ConsumerGroupMember.Builder(member1)
+ .setClassicMemberMetadata(new
ConsumerGroupMemberMetadataValue.ClassicMemberMetadata()
+ .setSupportedProtocols(roundRobinAndRangeProtocols))
+ .build();
+ consumerGroup.updateMember(member1);
+ member2 = new ConsumerGroupMember.Builder(member2)
+ .setClassicMemberMetadata(new
ConsumerGroupMemberMetadataValue.ClassicMemberMetadata()
+ .setSupportedProtocols(roundRobinAndRangeProtocols))
+ .build();
+ consumerGroup.updateMember(member2);
+
+ assertEquals(2,
consumerGroup.classicMembersSupportedProtocols().get("range"));
+ assertEquals(2,
consumerGroup.classicMembersSupportedProtocols().get("roundrobin"));
+
assertTrue(consumerGroup.supportsClassicProtocols(ConsumerProtocol.PROTOCOL_TYPE,
new HashSet<>(Arrays.asList("sticky", "roundrobin"))));
+ }
+
+ @Test
+ public void testAllUseClassicProtocol() {
Review Comment:
nit: testAllMembersUseClassicProtocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
