dajac commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1558996031


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java:
##########
@@ -20,16 +20,51 @@
 import org.apache.kafka.common.record.CompressionType;
 
 public class OffsetConfig {

Review Comment:
   @OmniaGM Thanks for working on this. I wonder whether we could merge 
`OffsetConfig` into `GroupCoordinatorConfig` in order to have one config for 
the entire package. It would bring us closer to the goal described in 
https://issues.apache.org/jira/browse/KAFKA-15089. Would it be possible? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to