dajac commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1559600382
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java:
##########
@@ -20,16 +20,51 @@
import org.apache.kafka.common.record.CompressionType;
public class OffsetConfig {
Review Comment:
`OffsetConfig` is only used by Scala code so it will disappear when we
remove it. The `GroupConfig` in Scala may never be migrated to Java as
`GroupCoordinatorConfig` already contains everything, I think. I wonder if we
could actually replace `OffsetConfig` by an interface and make
`GroupCoordinatorConfig` implements it. Then, we could pass
`GroupCoordinatorConfig` to the old code too. I am not sure if this is feasible
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
