CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343
########## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ########## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void handleUncleanBrokerShutdown(int brokerId, List<ApiMessageAndVersion> records) { replicationControl.handleBrokerUncleanShutdown(brokerId, records); } + + void maybeTriggerMinIsrConfigUpdate(Optional<String> topicName) throws InterruptedException, ExecutionException { + appendWriteEvent("partitionUpdateForMinIsrChange", OptionalLong.empty(), + () -> replicationControl.getPartitionElrUpdatesForConfigChanges(topicName)).get(); + } Review Comment: Then we only need to call appendWriteEvent here? We don't have to wait for the replay(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org