CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566471100
########## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ########## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) { log.info("Replayed ConfigRecord for {} which set configuration {} to {}", configResource, record.name(), record.value()); } + if (record.name() == TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG) { + try { + if (type == Type.TOPIC) { + minIsrConfigUpdatePartitionHandler.addRecordsForMinIsrUpdate(Optional.of(record.resourceName())); + } else { + minIsrConfigUpdatePartitionHandler.addRecordsForMinIsrUpdate(Optional.empty()); + } + } catch (InterruptedException | ExecutionException e) { + throw new Throwable("Fail to append partition updates for the min isr update: " + e.getMessage()); + } Review Comment: Removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org