OmniaGM commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574731972
########## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.config; + +import java.util.Collections; +import java.util.List; + +public class ServerQuotaConfigs { Review Comment: 1. We have 2 `QuotaConfigs` one in `client` and another in `DynamicConfig` and I was trying to avoid dealing with a third one in the code. 2. This config are also used for replication and controller mutations so it's not only client. I can call it `CommonQuotaConfigs` otherwise I can name it `QuotaConfigs` but will need to make sure we don't don't get into import ambiguity by importing each config prop or default value separately. ########## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.config; + +import java.util.Collections; +import java.util.List; + +public class ServerQuotaConfigs { Review Comment: 1. We have 2 `QuotaConfigs` one in `client` and another in `DynamicConfig` and I was trying to avoid dealing with a third one in the code. 2. This config are also used for replication and controller mutations so it's not only client. I can call it `CommonQuotaConfigs` otherwise I can name it `QuotaConfigs` but will need to make sure we don't get into import ambiguity by importing each config prop or default value separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
