mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576247775
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##########
@@ -98,23 +99,18 @@ public class ReassignPartitionsCommand {
static final int EARLIEST_TOPICS_JSON_VERSION = 1;
// Throttles that are set at the level of an individual broker.
- //DynamicConfig.Broker.LeaderReplicationThrottledRateProp
- static final String BROKER_LEVEL_LEADER_THROTTLE =
"leader.replication.throttled.rate";
- //DynamicConfig.Broker.FollowerReplicationThrottledRateProp
- static final String BROKER_LEVEL_FOLLOWER_THROTTLE =
"follower.replication.throttled.rate";
- //DynamicConfig.Broker.ReplicaAlterLogDirsIoMaxBytesPerSecondProp
- static final String BROKER_LEVEL_LOG_DIR_THROTTLE =
"replica.alter.log.dirs.io.max.bytes.per.second";
+ static final String BROKER_LEVEL_LEADER_THROTTLE =
QuotaConfigs.LEADER_REPLICATION_THROTTLED_RATE_CONFIG;
Review Comment:
Do we need to keep those fields? or could we directly use QuotaConfigs?
##########
checkstyle/import-control-metadata.xml:
##########
@@ -123,6 +123,7 @@
<allow pkg="org.apache.kafka.server.util" />
<allow pkg="org.apache.kafka.snapshot" />
<allow pkg="org.apache.kafka.test" />
+ <allow pkg="org.apache.kafka.server.config" />
Review Comment:
Nit: The list is roughly ordered, can we put
`org.apache.kafka.server.config` above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
