kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579760563
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -1338,7 +1339,14 @@ private CompletableFuture<Void>
enqueueConsumerRebalanceListenerCallback(Consume
Set<TopicPartition> partitions) {
SortedSet<TopicPartition> sortedPartitions = new
TreeSet<>(TOPIC_PARTITION_COMPARATOR);
sortedPartitions.addAll(partitions);
- CompletableBackgroundEvent<Void> event = new
ConsumerRebalanceListenerCallbackNeededEvent(methodName, sortedPartitions);
+
+ // We don't yet have the concept of having an expiring callback, but
we will likely want that eventually.
+ Timer timer = time.timer(Long.MAX_VALUE);
+ CompletableBackgroundEvent<Void> event = new
ConsumerRebalanceListenerCallbackNeededEvent(
+ methodName,
+ sortedPartitions,
+ timer
+ );
Review Comment:
I'll look into how to do this in a way that I don't find too ugly 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
