kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579914824
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -769,7 +730,8 @@ public void commitAsync(OffsetCommitCallback callback) {
public void commitAsync(Map<TopicPartition, OffsetAndMetadata> offsets,
OffsetCommitCallback callback) {
acquireAndEnsureOpen();
try {
- AsyncCommitEvent asyncCommitEvent = new AsyncCommitEvent(offsets);
+ Timer timer = time.timer(Long.MAX_VALUE);
+ AsyncCommitEvent asyncCommitEvent = new AsyncCommitEvent(offsets,
timer);
Review Comment:
I was able to refactor the code to eliminate the need for passing in a
`Timer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
