dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583163477
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1524,7 +1524,8 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
new ConsumerGroupHeartbeatResponseData()
.setMemberId(memberId)
.setMemberEpoch(memberEpoch),
- appendFuture
+ appendFuture,
+ appendFuture == null
Review Comment:
I understand why we need it here but I find it fragile because having an
`appendFuture` may not be coupled with requiring to replay now. I wonder if we
could push the creation of the `CoordinatorResult` to
`consumerGroupFenceMember` and `consumerGroupStaticMemberGroupLeave`. Have you
considered it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
