dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583572562
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1560,13 +1561,15 @@ private List<Record>
consumerGroupStaticMemberGroupLeave(
* @param records The list of records to be applied to the state.
* @return The append future to be applied.
*/
- private CompletableFuture<Void> consumerGroupFenceMember(
+ private <T> CoordinatorResult<T, Record> consumerGroupFenceMember(
ConsumerGroup group,
ConsumerGroupMember member,
- List<Record> records
+ List<Record> records,
+ T response
) {
if (validateOnlineDowngrade(group, member.memberId())) {
- return convertToClassicGroup(group, member.memberId(), records);
+ CompletableFuture<Void> appendFuture =
convertToClassicGroup(group, member.memberId(), records);
Review Comment:
moved `CoordinatorResult` to `convertToClassicGroup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
