philipnee commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585558712
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##########
@@ -30,12 +29,7 @@ public abstract class CommitEvent extends
CompletableApplicationEvent<Void> {
*/
private final Map<TopicPartition, OffsetAndMetadata> offsets;
- protected CommitEvent(final Type type, final Map<TopicPartition,
OffsetAndMetadata> offsets, final Timer timer) {
- super(type, timer);
- this.offsets = validate(offsets);
- }
-
- protected CommitEvent(final Type type, final Map<TopicPartition,
OffsetAndMetadata> offsets, final long deadlineMs) {
+ public CommitEvent(final Type type, Map<TopicPartition, OffsetAndMetadata>
offsets, final long deadlineMs) {
Review Comment:
ditto: we probably don't need the final but it would be good to be
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
