lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585091606
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection<String>
topics, Optional<ConsumerRebal
* @return {@code true} if the event completed within the timeout, {@code
false} otherwise
*/
// Visible for testing
- <T> T processBackgroundEvents(EventProcessor<?> eventProcessor,
+ <T> T processBackgroundEvents(EventProcessor<BackgroundEvent>
eventProcessor,
Review Comment:
Also, regarding:
> as part of this rebalancing work, the {@link
ConsumerRebalanceListener#onPartitionsRevoked(Collection)} callback needs to be
invoked
it does not need to if the consumer unsubscribing does not own any
partition, so just for accuracy in the example I would suggest to extend it
with "...needs to be invoked for the partitions the consumer owns"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
