jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586760874
########## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java: ########## @@ -216,4 +140,132 @@ private void appendBatches(List<CompletedBatch<T>> batches) { batches.forEach(CompletedBatch::release); } } + + final public static class Builder { + private long lastContainedLogTimestamp = 0; + private CompressionType compressionType = CompressionType.NONE; + private Time time = Time.SYSTEM; + private int maxBatchSize = 1024; + private MemoryPool memoryPool = MemoryPool.NONE; + private short kraftVersion = 0; Review Comment: In practice `KafkaRaftClient` will override all of these defaults. I set the default to what would make sense to use in most cases in `**/src/test`. This is why `maxBatchSize` is 1024 for example. We use a similar strategy in the `metadata` module. The builder's default is what would make sense in most tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org