jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586828276


##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -206,8 +151,16 @@ private static Integer parseVoterId(String idString) {
         }
     }
 
-    public static Map<Integer, AddressSpec> parseVoterConnections(List<String> 
voterEntries) {
-        Map<Integer, AddressSpec> voterMap = new HashMap<>();
+    public static Map<Integer, InetSocketAddress> 
parseVoterConnections(List<String> voterEntries) {
+        return parseVoterConnections(voterEntries, true);
+    }
+
+    public static Set<Integer> parseVoterIds(List<String> voterEntries) {
+        return parseVoterConnections(voterEntries, false).keySet();
+    }
+
+    private static Map<Integer, InetSocketAddress> 
parseVoterConnections(List<String> voterEntries, boolean routableOnly) {

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to