cadonna commented on code in PR #15852:
URL: https://github.com/apache/kafka/pull/15852#discussion_r1589352418
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -191,14 +193,20 @@ private void performActionsOnTasks() {
tasksAndActionsLock.lock();
try {
for (final TaskAndAction taskAndAction : getTasksAndActions())
{
- final Action action = taskAndAction.getAction();
+ final Action action = taskAndAction.action();
switch (action) {
case ADD:
- addTask(taskAndAction.getTask());
+ addTask(taskAndAction.task());
break;
case REMOVE:
- removeTask(taskAndAction.getTaskId());
+ if (taskAndAction.futureForRemove() == null) {
Review Comment:
No, we do not but for the sake of breaking down my gigantic PR, I need to
temporary keep it until one of my future PRs makes it obsolete. It will be
simply called `remove()` after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
