cadonna commented on code in PR #15852: URL: https://github.com/apache/kafka/pull/15852#discussion_r1590755586
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ########## @@ -506,16 +506,14 @@ private void addTask(final Task task) { private void removeTask(final TaskId taskId, final CompletableFuture<RemovedTaskResult> future) { try { - if (updatingTasks.containsKey(taskId)) { - removeUpdatingTask(taskId, future); - } else if (pausedTasks.containsKey(taskId)) { - removePausedTask(taskId, future); - } else { - if (!removeRestoredTask(taskId, future)) { - if (!removeFailedTask(taskId, future)) { - future.complete(null); - log.warn("Task " + taskId + " could not be removed from the state updater because " - + "the state updater does not own this task."); + if (!removeUpdatingTask(taskId, future)) { Review Comment: Oh, thanks! I am going to change that in one of my future PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org