lianetm commented on PR #15844: URL: https://github.com/apache/kafka/pull/15844#issuecomment-2096155474
One concern on [comment](https://github.com/apache/kafka/pull/15844#discussion_r1591065112) above about how we identify this situation (inflight fetch requests that we shouldn't delete too soon). Another one about where to consider the situation. Inflight requests are removed in 2 places: direct call to fetch (handled in this PR), but also from the commit manager poll. The commit manager (as other managers) has logic for removing all expired requests in its poll loop, when calling [failAndRemoveExpiredFetchRequests](https://github.com/apache/kafka/blob/42754336e1ff35cb45661f1a906fc24b761b27cf/clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java#L1182). Shouldn't we consider that too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
