kirktrue commented on code in PR #15844:
URL: https://github.com/apache/kafka/pull/15844#discussion_r1598899793
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1145,14 +1141,42 @@ private CompletableFuture<Map<TopicPartition,
OffsetAndMetadata>> addOffsetFetch
inflightOffsetFetches.stream().filter(r ->
r.sameRequest(request)).findAny();
if (dupe.isPresent() || inflight.isPresent()) {
- log.info("Duplicated OffsetFetchRequest: " +
request.requestedPartitions);
- dupe.orElseGet(inflight::get).chainFuture(request.future);
+ log.info("Duplicate OffsetFetchRequest found for partitions:
{}", request.requestedPartitions);
+ OffsetFetchRequestState originalRequest =
dupe.orElseGet(inflight::get);
+ originalRequest.chainFuture(request.future);
} else {
this.unsentOffsetFetches.add(request);
}
return request.future;
}
+ /**
+ * Remove the {@link OffsetFetchRequestState request} from the
inflight requests queue <em>iff</em>
+ * both of the following are true:
+ *
+ * <ul>
+ * <li>The request completed with a <code>null</code> {@link
Throwable error}</li>
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
