lianetm commented on PR #15869: URL: https://github.com/apache/kafka/pull/15869#issuecomment-2101139225
Hey @Phuc-Hong-Tran , thanks for the changes, left some comments. Could we add unit tests for this? Definitely helpful to validate the main goal of this patch, which is to ensure the regex in only evaluated once, and not on following calls to poll (when metadata remains unchanged). I would suggest playing with the mocks of the metadata object to mock values for `metadata.updateVersion()`, and verify calls to `subscription.matchesSubscribedPattern(topic)`. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
