lianetm commented on code in PR #15869:
URL: https://github.com/apache/kafka/pull/15869#discussion_r1603504298
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -463,6 +467,42 @@ public void onPartitionsAssigned(final
Collection<TopicPartition> partitions) {
assertTrue(callbackExecuted.get());
}
+ @Test
+ public void testCheckForNewTopicOnlyWhenMetadataChange() {
+ SubscriptionState subscriptions = mock(SubscriptionState.class);
+ Cluster cluster = mock(Cluster.class);
+
+ consumer = newConsumer(
+ mock(FetchBuffer.class),
+ mock(ConsumerInterceptors.class),
+ mock(ConsumerRebalanceListenerInvoker.class),
+ subscriptions,
+ singletonList(new RoundRobinAssignor()),
Review Comment:
we should not have to deal with the old assignors in the new consumer, so
this made me notice we have a bug that makes you have to provide this. That
needs to be fixed, so I filed https://issues.apache.org/jira/browse/KAFKA-16786
for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
