chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1597469917
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM) extends Logging with
BrokerReconfigurable {
// Visible for test.
private[log] val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ activateMetrics()
Review Comment:
> some of the test cases would fail. The metric would not be initialized. Is
there a better way to refactor that? thanks!
Could you please share the test cases to me? Maybe they do not call
`startup`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
