chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1599475760
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review Comment:
> I reckon the metrics in LogCleanerManager would remained removed? Perhaps
they shouldn't be removed while reconfiguring?
@gaurav-narula that is a good point.
@chiacyu Could you write ut to verify that metrics of `LogCleanerManager`
are not removed after reconfiguration. Also, @gaurav-narula's suggestion is a
better way I feel. Could you please give a try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
