cmccabe commented on code in PR #15876:
URL: https://github.com/apache/kafka/pull/15876#discussion_r1599218840
##########
clients/src/main/resources/common/message/ElectLeadersRequest.json:
##########
@@ -32,7 +32,9 @@
{ "name": "Topic", "type": "string", "versions": "0+", "entityType":
"topicName", "mapKey": true,
"about": "The name of a topic." },
{ "name": "Partitions", "type": "[]int32", "versions": "0+",
- "about": "The partitions of this topic whose leader should be
elected." }
+ "about": "The partitions of this topic whose leader should be
elected." },
+ { "name": "DesiredLeaders", "type": "[]int32", "versions": "3+",
"nullableVersions": "3+",
+ "about": "The desired leaders. The entry should match with the entry
in Partitions by the index." }
Review Comment:
Please specify that this is only for DESIGNATED elections. Also, please
change the name to `designatedLeaders` (we shouldn't mix terminiology -- pick
one term, like "designated", and stick with it, rather than having designated /
desired / specified all over the place.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
