cmccabe commented on code in PR #15876:
URL: https://github.com/apache/kafka/pull/15876#discussion_r1599220921


##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -1786,6 +1786,105 @@ object TestUtils extends Logging {
       KafkaYammerMetrics.defaultRegistry.removeMetric(metricName)
   }
 
+  def clearYammerMetricsExcept(names: Set[String]): Unit = {

Review Comment:
   This seems like a pretty heavy hammer that might cause problems, given that 
so many tests modify global metrics state. Why do we need this now, when we 
didn't before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to