cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1599698758
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ########## Review Comment: Usually if it takes some contortion to write unit tests, then there is usually a code smell somewhere. 🤔 Unit tests do not only test code in execution, but often also help to design components that have loose coupling and high cohesion. ########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ########## Review Comment: See my comment above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
