kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1602381867
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -88,6 +91,7 @@ public class ConsumerNetworkThreadTest {
private CommitRequestManager commitRequestManager;
private CoordinatorRequestManager coordinatorRequestManager;
private ConsumerNetworkThread consumerNetworkThread;
+ private CompletableEventReaper applicationEventReaper;
Review Comment:
Done
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -294,6 +299,46 @@ void testEnsureEventsAreCompleted() {
assertTrue(applicationEventsQueue.isEmpty());
}
+ @Test
+ void testReaperExpiresExpiredEvents() {
Review Comment:
Agreed. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
