johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601745613
##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -153,13 +153,13 @@ public Map<Integer, Map<String, String>>
perServerOverrideProperties() {
return perServerProperties;
}
- public Optional<List<String>> tags() {
- return Optional.ofNullable(tags);
+ public List<String> tags() {
+ return tags;
}
public Set<String> displayTags() {
Set<String> displayTags = new LinkedHashSet<>(tags);
- tags().ifPresent(tags -> displayTags.add("tags=" + tags));
+ displayTags.add("tags=" + String.join(",", tags));
Review Comment:
oops yes you are right, let me remove that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
