johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601750727
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -66,8 +67,8 @@ static void generate1(ClusterGenerator clusterGenerator) {
serverProperties.put("foo", "bar");
clusterGenerator.accept(ClusterConfig.defaultBuilder()
.setTypes(Collections.singleton(Type.ZK))
- .setName("Generated Test")
.setServerProperties(serverProperties)
+ .setTags(Arrays.asList("name", "Generated Test"))
Review Comment:
thanks for the comment!
`singletonList` is a more flexible wrapper of a list, that's the reason why
it's better than just using Arrays, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
