mimaison commented on PR #15834: URL: https://github.com/apache/kafka/pull/15834#issuecomment-2112826872
Thanks for the PR. If I set `inter.broker.protocol.version=3.6-IV2` and multiple log directories in my broker configuration, it now prevents me from formatting the storage: ``` bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties [2024-05-15 17:05:31,009] WARN inter.broker.protocol.version is deprecated in KRaft mode as of 3.3 and will only be read when first upgrading from a KRaft prior to 3.3. See kafka-storage.sh help for details on setting the metadata.version for a new KRaft cluster. (kafka.server.KafkaConfig) Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: Multiple log directories (aka JBOD) are not supported in the configured inter.broker.protocol.version 3.0-IV1. Need 3.7-IV2 or higher ``` However, if I specify the metadata version using the `--release-version` flag of the storage tool, the formatting works and I only get the failure when I try to start the broker: ``` bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties --release-version 3.6 metaPropertiesEnsemble=MetaPropertiesEnsemble(metadataLogDir=Optional.empty, dirs={/tmp/kraft-combined-logs: EMPTY, /tmp/kraft-combined-logs2: EMPTY}) Formatting /tmp/kraft-combined-logs with metadata.version 3.6-IV2. Formatting /tmp/kraft-combined-logs with metadata.version 3.6-IV2. Formatting /tmp/kraft-combined-logs2 with metadata.version 3.6-IV2. ``` Should we ensure the failure always happens at the formatting stage? I also created https://issues.apache.org/jira/browse/KAFKA-16771 to avoid printing the "Formatting <...>" log line twice for the first directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org