dajac commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1602677561
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##########
@@ -1072,8 +1174,8 @@ public void replay(
@Test
public void testScheduleWriteOpWhenWriteFails() {
MockTimer timer = new MockTimer();
- // The partition writer only accept on write.
- MockPartitionWriter writer = new MockPartitionWriter(2);
+ // The partition writer only accept one write.
Review Comment:
You got it right. A write operation produces a single batch with all the
records generated by it. This patch does not change it but change where the
memory record is built. The next patch will add the logic to keep the batch
open until full or until a linger time is reached. With this, records produced
by many write operations will end up in the same batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
